Repository navigation
fix(nav3): Prevent NaN and infinite arguments from dropping SentryEvents and SentryTransactions - #6713
Open
0xadam-brown wants to merge 2 commits into
Open
fix(nav3): Prevent NaN and infinite arguments from dropping SentryEvents and SentryTransactions#67130xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
Keep navigation arguments JSON-compatible so non-finite numbers cannot prevent the containing report from being serialized. Refs JAVA-787
Contributor
PR risk: mediumFor commit Main concerns: data sent to Sentry, host performance, reach. This label is a hint for reviewers, not an approval. |
📲 Install BuildsAndroid
|
0xadam-brown
marked this pull request as ready for review
November 20, 2026 16:16
0xadam-brown
requested review from
markushi and
runningcode
and removed request for
a team
November 20, 2026 16:16
6 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
PR fixes an edge-case bug in our Nav3 integration that could cause SentryEvents or Transactions to be dropped SDK-side if back stack entry arguments contained non-finite numeric values.
Now we convert NaN and positive or negative infinity values in back stack entry arguments to strings instead of passing them to the transport layer's JSON serializer unchanged.
💡 Motivation and Context
Our Nav3 integration attaches nav arguments to SentryEvents and SentryTransactions. JSON can't represent NaN or infinity, so an argument containing one of those values can cause serialization of the entire event or transaction to fail. Converting these values to strings preserves the argument’s value while allowing the containing event or transaction to be sent.
💚 How did you test it?
Unit tests + regression tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps